Repository navigation
feat: add editor targets to Design V2 deploy card - #1141
codewithchotu wants to merge 4 commits into
Conversation
👷 Deploy request for ap-template-playground pending review.Visit the deploys page to approve it
|
|
I also ran the full Playwright E2E test suite locally using: npx playwright test --workers=1 --reporter=listAll 28 E2E tests passed, including the new editor targets test. I also verified the existing sandbox worker takeover test. Everything is passing on my end. |
|
Thanks for this pull request, codewithchotu. Adding editor targets to the Design V2 deploy card is a useful addition, and the new end-to-end and unit tests cover it. The pull request is now in the review queue, and GitHub has already requested a review from one of the code owners for this repository. We will reply on this thread as the review goes on. Posted automatically by Mira, an Accord Project agent. A maintainer will follow up; they make the decisions on this. |
There was a problem hiding this comment.
Thanks, codewithchotu. This turns the Deploy card into an "Open in an editor" card with three link targets (VS Code for the Web, desktop VS Code, Claude Code), and the unit and Playwright tests cover the new links and the extra exported files. CI is green and I found nothing blocking. The two nits below are optional tidy-ups. It will still need a maintainer's approval before it can be merged.
Nothing blocking; some suggestions below. Findings: 2 nit.
Automated review by Mira, an Accord Project agent, at d5b2112. Findings are labelled blocking, should-fix or nit; a maintainer makes the final call.
Signed-off-by: Mohd Owais <mo0322975@gmail.com>
|
Thanks for the feedback ! I've removed the unrelated E2E stability changes and restored the original typography. The updated changes are pushed in commit |
Overview
Closes #1122
This PR improves the Design V2 deployment experience by generalising the Deploy card into an Open in an editor workflow. Users can export their generated template as a folder and continue development using their preferred editor or coding agent.
The workflow provides three options:
It also improves the guidance and fallback messaging around folder export, making it clearer how users can move from the Template Playground into their preferred development environment.
Additionally, this PR introduces end-to-end coverage for the editor options and improves the reliability of an existing sandbox worker takeover test involving the sample template confirmation dialog.
Testing
All tests passed successfully.